Skip to content

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jun 22, 2020

What is changed, added or deleted? (Required)

Add system performance tuning doc to guide how to tuning linux system.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-2.1 special-week PR from Document Special Week. labels Jun 22, 2020
@TomShawn TomShawn requested review from ethercflow and yikeke June 22, 2020 09:45
@TomShawn TomShawn marked this pull request as ready for review June 22, 2020 09:45
@yikeke yikeke requested review from lilin90 and removed request for yikeke June 24, 2020 03:10
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. size/large Changes of a large size. labels Jun 30, 2020
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Network tuning section to be reviewed soon.

@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jun 30, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
TomShawn and others added 2 commits June 30, 2020 20:18
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 1, 2020
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jul 2, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 2, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 2, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @lilin90, you don't have permission to trigger auto merge event on this branch. The number of LGTM for this PR is 0 while it needs 2 at least

@lilin90 lilin90 removed the status/PTAL This PR is ready for reviewing. label Jul 2, 2020
@AndreMouche
Copy link
Contributor

LGTM

Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@AndreMouche, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@lilin90 lilin90 merged commit 06124fe into pingcap:master Jul 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-2.1 in PR #3118

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #3119

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #3120

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3121

TomShawn added a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn deleted the tune-operating-sys branch July 2, 2020 12:04
ti-srebot added a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
ti-srebot added a commit that referenced this pull request Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
TomShawn added a commit that referenced this pull request Jul 2, 2020
* cherry pick #2988 to release-3.1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update TOC.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/large Changes of a large size. special-week PR from Document Special Week. status/LGT1 Indicates that a PR has LGTM 1. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants