Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 23, 2020

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

part of pingcap/docs-cn#3532,
pingcap/docs-cn#3599,
a link from pingcap/docs-cn#3341

  • Other reference link(s):

@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 23, 2020
@yikeke yikeke removed request for ilovesoup and kissmydb June 23, 2020 13:29
@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 23, 2020
@yikeke yikeke requested review from flowbehappy and removed request for zanmato1984 June 23, 2020 13:30
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

@ti-srebot
Copy link
Contributor

@TomShawn, @flowbehappy, PTAL.

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jun 28, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 28, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4627248 into master Jun 28, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3044

ti-srebot added a commit that referenced this pull request Jun 28, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@yikeke yikeke deleted the update-tiflash-config branch June 28, 2020 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants