update functions-and-operator and generated-columns #3051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
PTAL @Reminiscent |
yikeke
added
needs-cherry-pick-4.0
status/PTAL
Contributor
|
@SunRunAway, @yikeke, PTAL. |
ran-huang
reviewed
Jul 2, 2020
ran-huang
changed the title
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
Co-authored-by: Ran <huangran@pingcap.com>
ran-huang
reviewed
Jul 3, 2020
Contributor
|
@ran-huang,Thanks for your review. |
Contributor
|
@niezefeng, please update your pull request. |
Contributor
|
@ran-huang, @ti-srebot, @SunRunAway, @wjhuang2016, PTAL. |
wjhuang2016
reviewed
Jul 6, 2020
generated-columns.md
Outdated
| - You can neither convert a generated stored column to a normal column through the `ALTER TABLE` statement nor convert a normal column to a generated stored column. | ||
| - You cannot modify the **expression** of a generated stored column through the `ALTER TABLE` statement. | ||
| - Not all [JSON functions](/functions-and-operators/json-functions.md) are supported. | ||
| - You cannot add the generated column through `ALTER TABLE`. |
Member
There was a problem hiding this comment.
You cannot add the stored generated column through ALTER TABLE.
Contributor
|
@wjhuang2016 Comments addressed. PTAL again. Thanks~ |
Contributor
|
@wjhuang2016, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack). |
Contributor
|
/merge |
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Jul 6, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
5 tasks
Contributor
|
cherry pick to release-4.0 in PR #3172 |
ti-srebot
added a commit
that referenced
this pull request
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
Update functions-and-operator documents and json-functions documents.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?