Skip to content

Conversation

@tiancaiamao
Copy link
Contributor

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@yikeke yikeke requested review from winoros and yikeke June 30, 2020 03:21
@yikeke yikeke added needs-cherry-pick-4.0 status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jun 30, 2020
@ti-srebot
Copy link
Contributor

@winoros, @yikeke, PTAL.

2 similar comments
@ti-srebot
Copy link
Contributor

@winoros, @yikeke, PTAL.

@ti-srebot
Copy link
Contributor

@winoros, @yikeke, PTAL.

@yikeke
Copy link
Contributor

yikeke commented Jul 10, 2020

I made two commits to improve wording, format, punctuation, links, styles, etc. Feel free to comment on them if you have any problems. @tiancaiamao

And this PR should be merged after #3043 merges because of this link. The CI failed because of it now.

@ti-srebot
Copy link
Contributor

@yikeke, @winoros, PTAL.

Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 13, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 13, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 13, 2020

Good job! @tiancaiamao

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@tiancaiamao merge failed.

@yikeke
Copy link
Contributor

yikeke commented Jul 13, 2020

ah I forgot that this PR should be merged after #3043 get merged.

@yikeke yikeke merged commit 7bee86a into pingcap:master Jul 15, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3279

yikeke added a commit that referenced this pull request Jul 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: tiancaiamao <tiancaiamao@gmail.com>
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants