Skip to content

Update grafana-monitor-best-practices.md and tispark doc #3073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 3, 2020
Merged

Update grafana-monitor-best-practices.md and tispark doc #3073

merged 4 commits into from
Jul 3, 2020

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jun 30, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@github-actions github-actions bot added translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. status/PTAL This PR is ready for reviewing. labels Jun 30, 2020
@yikeke yikeke added needs-cherry-pick-2.1 size/small Changes of a small size. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jun 30, 2020
@yikeke yikeke removed the request for review from lilin90 June 30, 2020 04:12
@yikeke yikeke requested a review from marsishandsome June 30, 2020 04:38
@yikeke yikeke changed the title Update grafana-monitor-best-practices.md Update grafana-monitor-best-practices.md and tispark doc Jun 30, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 2, 2020

@marsishandsome, @kissmydb, @TomShawn, PTAL.

TomShawn
TomShawn reviewed Jul 2, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@yikeke @TomShawn
Apply suggestions from code review
94feb55 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@yikeke
Copy link
Contributor Author

yikeke commented Jul 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 3, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 3, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 9e8c7cb into master Jul 3, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3073 to release-2.1
72b23f2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 3, 2020

cherry pick to release-2.1 in PR #3124

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3073 to release-3.0
a4dfbce 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 3, 2020

cherry pick to release-3.0 in PR #3125

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3073 to release-3.1
d3c4b98 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 3, 2020

cherry pick to release-3.1 in PR #3126

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 3, 2020
@yikeke @ti-srebot
cherry pick pingcap#3073 to release-4.0
71127ae 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 3, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 3, 2020

cherry pick to release-4.0 in PR #3127

@yikeke yikeke deleted the update-grafana-best-practice- branch July 3, 2020 02:42
yikeke added a commit that referenced this pull request Jul 3, 2020
@ti-srebot @yikeke
cherry pick #3073 to release-2.1 (#3124)
9edcd2a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke added a commit that referenced this pull request Jul 3, 2020
@ti-srebot @yikeke
cherry pick #3073 to release-3.0 (#3125)
4538984 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke added a commit that referenced this pull request Jul 3, 2020
@ti-srebot @yikeke
cherry pick #3073 to release-3.1 (#3126)
5708902 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
yikeke added a commit that referenced this pull request Jul 3, 2020
@ti-srebot @yikeke
cherry pick #3073 to release-4.0 (#3127)
fe7882a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kissmydb kissmydb Awaiting requested review from kissmydb

@marsishandsome marsishandsome Awaiting requested review from marsishandsome

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yikeke @ti-srebot @TomShawn