Skip to content

grafana-pd-dashboard: Update pd dashboard #3117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2020
Merged

grafana-pd-dashboard: Update pd dashboard #3117

merged 6 commits into from
Jul 9, 2020

Conversation

@shenli
Copy link
Member

@shenli shenli commented Jul 2, 2020 •
edited by lilin90
Loading

What is changed, added or deleted? (Required)

Update pd dashboard according to pingcap/docs-cn#3343

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@lilin90 lilin90 requested review from lilin90 and nolouch July 2, 2020 11:42
@lilin90 lilin90 added the size/medium Changes of a medium size. label Jul 2, 2020
@lilin90 lilin90 added status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 2, 2020
lilin90
lilin90 reviewed Jul 2, 2020
View reviewed changes
@shenli
Copy link
Member Author

shenli commented Jul 4, 2020

@nolouch PTAL

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 6, 2020

@lilin90, @nolouch, PTAL.

lilin90
lilin90 reviewed Jul 6, 2020
View reviewed changes
lilin90
lilin90 reviewed Jul 7, 2020
View reviewed changes
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jul 7, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

@lilin90, @nolouch, PTAL.

lilin90
lilin90 approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @nolouch PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 9, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

@lilin90,Thanks for your review.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

@nolouch, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:docs(slack).

@lilin90
Copy link
Member

lilin90 commented Jul 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 9, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 1903dd3 into pingcap:master Jul 9, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 9, 2020
@shenli @ti-srebot
cherry pick pingcap#3117 to release-4.0
82f405e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 9, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 9, 2020

cherry pick to release-4.0 in PR #3216

lilin90 pushed a commit that referenced this pull request Jul 9, 2020
@ti-srebot @shenli
cherry pick #3117 to release-4.0 (#3216)
cd13259 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Shen Li <shenli3514@gmail.com>
@shenli shenli deleted the docs-cn-3343 branch July 10, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nolouch nolouch nolouch approved these changes

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees

No one assigned

Labels

size/medium Changes of a medium size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. status/require-change Needs the author to address comments. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shenli @ti-srebot @lilin90 @nolouch