Skip to content

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Jul 9, 2020

What is changed, added or deleted? (Required)

Add wrong-index-solution.

Note: CI fails because a link anchor (Count-Min Sketch) waits on the translation of pingcap/docs-cn#3223.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ran-huang ran-huang requested review from winoros and yikeke July 9, 2020 11:27
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 9, 2020
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-srebot ti-srebot added status/LGT1 Indicates that a PR has LGTM 1. labels Jul 17, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 17, 2020

Please fix the lint. @ran-huang

@yikeke yikeke added require-LGT1 Indicates that the PR requires an LGTM. and removed require-LGT1 Indicates that the PR requires an LGTM. labels Jul 17, 2020
@ran-huang
Copy link
Contributor Author

Please fix the lint. @ran-huang

@yikeke Thanks, but the lint has to wait until this PR (pingcap/docs-cn#3223) is translated by Joyce.

ran-huang and others added 2 commits July 20, 2020 10:25
Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com>
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Jul 20, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 20, 2020

Please fix the lint. @ran-huang

@yikeke Thanks, but the lint has to wait until this PR (pingcap/docs-cn#3223) is translated by Joyce.

Waiting on #3332. Could you please review #3332? @ran-huang

@ran-huang
Copy link
Contributor Author

@winoros PTAL. Thanks~

@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 22, 2020
@yikeke
Copy link
Contributor

yikeke commented Jul 22, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1bcd704 into pingcap:master Jul 22, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3365

ti-srebot added a commit that referenced this pull request Jul 22, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ran-huang ran-huang deleted the wrong-index-solution branch July 30, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants