Skip to content

Update TiDB upgrade FAQ #3218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 17, 2020
Merged

Update TiDB upgrade FAQ #3218

merged 8 commits into from
Jul 17, 2020

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Jul 10, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Merged the upgrade part in TiDB FAQs installation deployment upgrade with the current Upgrade FAQs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 10, 2020

/label size/small, translation/from-docs-cn, status/PTAL,

@ti-srebot ti-srebot added size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 10, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 10, 2020

These labels are not found ``.

@yikeke yikeke requested review from glkappe and lilin90 July 13, 2020 03:16
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 14, 2020

@glkappe, @lilin90, PTAL.

@lilin90 lilin90 changed the title translate add-upgrade-faq Update TiDB upgrade FAQ Jul 14, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 14, 2020 •
edited
Loading

@Joyinqin In your PR description, you says "Translate add-upgrade-faq.md", but we don't have such a file. Instead, the file name is upgrade-faq.md.

And it would be more friendly to reviewers if you add a link of the Chinese version on the PingCAP website. For example:

Translate add-upgrade-faq.md > Update TiDB upgrade FAQ

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

@glkappe, @lilin90, PTAL.

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

These labels are not found needs-cherry-pick 4.0.

@Joyinqin
Copy link
Contributor Author

Joyinqin commented Jul 17, 2020

/label needs-cherry-pick-4.0

lilin90
lilin90 reviewed Jul 17, 2020
View reviewed changes
lilin90
lilin90 approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2020
@lilin90 lilin90 added the require-LGT1 Indicates that the PR requires an LGTM. label Jul 17, 2020
@lilin90
Copy link
Member

lilin90 commented Jul 17, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 17, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit abaa4ad into pingcap:master Jul 17, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 17, 2020
@Joyinqin @ti-srebot
cherry pick pingcap#3218 to release-4.0
4343ab5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 17, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 17, 2020

cherry pick to release-4.0 in PR #3321

lilin90 added a commit that referenced this pull request Jul 17, 2020
@ti-srebot @Joyinqin @lilin90
Update TiDB upgrade FAQ (#3218) (#3321)
055a0dc 
* cherry pick #3218 to release-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

* Update metadata

Co-authored-by: JoyinQ <56883733+Joyinqin@users.noreply.github.com>
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@glkappe glkappe Awaiting requested review from glkappe

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Joyinqin @ti-srebot @lilin90