Skip to content

Update tiup-playground.md #3271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2020
Merged

Update tiup-playground.md #3271

merged 3 commits into from
Jul 16, 2020

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Jul 14, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

update playground docs.
add about pump&drainer and more command

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-4.0 labels Jul 14, 2020
@TomShawn TomShawn requested review from july2993 and ran-huang July 14, 2020 13:43
ran-huang
ran-huang reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@ran-huang ran-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

@july2993,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn
Copy link
Contributor Author

TomShawn commented Jul 16, 2020

@ran-huang Please help approve this PR, thanks!

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Jul 16, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

@TomShawn Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Jul 16, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit d9a5be7 into pingcap:master Jul 16, 2020
@TomShawn TomShawn deleted the update-playgound-doca branch July 16, 2020 07:07
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 16, 2020
@TomShawn @ti-srebot
cherry pick pingcap#3271 to release-4.0
cf95d19 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 16, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 16, 2020

cherry pick to release-4.0 in PR #3294

ti-srebot added a commit that referenced this pull request Jul 16, 2020
@ti-srebot
Update tiup-playground.md (#3271) (#3294)
f8b77d7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@july2993 july2993 july2993 approved these changes

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TomShawn @ti-srebot @july2993 @ran-huang