Skip to content

dashboard: update grafana-overview-dashboard.md #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2020
Merged

dashboard: update grafana-overview-dashboard.md #3347

merged 4 commits into from
Jul 22, 2020

Conversation

@toutdesuite
Copy link
Contributor

@toutdesuite toutdesuite commented Jul 21, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

update grafana-overview-dashboard.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@toutdesuite toutdesuite requested review from TomShawn and bb7133 July 21, 2020 02:32
@toutdesuite toutdesuite added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Jul 21, 2020
TomShawn
TomShawn reviewed Jul 21, 2020
View reviewed changes
@toutdesuite @TomShawn
Apply suggestions from code review
fd49a11 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

TomShawn commented Jul 22, 2020 •
edited
Loading

LGTM
@bb7133 PTAL

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 22, 2020

LGTM

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 22, 2020

@bb7133,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 22, 2020

@bb7133,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@toutdesuite toutdesuite added the status/can-merge Indicates a PR has been approved by a committer. label Jul 22, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 22, 2020

@toutdesuite Oops! This PR requires at least 2 LGTMs to merge. The current number of LGTM is 1.

toutdesuite
toutdesuite commented Jul 22, 2020
View reviewed changes
Copy link
Contributor Author

@toutdesuite toutdesuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pingcap pingcap deleted a comment from ti-srebot Jul 22, 2020
TomShawn
TomShawn approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toutdesuite toutdesuite merged commit db91996 into pingcap:master Jul 22, 2020
@toutdesuite toutdesuite deleted the Overview-metrics branch July 22, 2020 14:09
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jul 22, 2020
@toutdesuite @ti-srebot
cherry pick pingcap#3347 to release-4.0
bb10c09 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Jul 22, 2020

cherry pick to release-4.0 in PR #3385

toutdesuite added a commit that referenced this pull request Jul 22, 2020
@ti-srebot @toutdesuite
cherry pick #3347 to release-4.0 (#3385)
a8f7294 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: toutdesuite <guizhiluo2014@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 approved these changes

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@toutdesuite @TomShawn @bb7133 @ti-srebot