Skip to content

Fix three deployment links in FAQ (#3381) #3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix three deployment links in FAQ (#3381) #3382

merged 1 commit into from
Jul 22, 2020

Conversation

@ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jul 22, 2020

cherry-pick #3381 to release-4.0

What is changed, added or deleted? (Required)

Fix three links introduced in #3240

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@lilin90 @ti-srebot
cherry pick pingcap#3381 to release-4.0
7eef0d2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 22, 2020
Merged
9 tasks
@ti-srebot ti-srebot added size/small Changes of a small size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Jul 22, 2020
@ti-srebot ti-srebot requested a review from TomShawn July 22, 2020 12:15
TomShawn
TomShawn approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Jul 22, 2020
@ti-srebot
Copy link
Contributor Author

ti-srebot commented Jul 22, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit cc11585 into pingcap:release-4.0 Jul 22, 2020
@lilin90 lilin90 deleted the release-4.0-64cf1a595085 branch July 22, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lilin90 lilin90

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-srebot @TomShawn @lilin90