Skip to content

Conversation

@yikeke
Copy link
Contributor

@yikeke yikeke commented Jul 23, 2020

What is changed, added or deleted? (Required)

Align:

pingcap/docs-cn#3170, pingcap/docs-cn#3258, pingcap/docs-cn#3248, pingcap/docs-cn#3149, https://github.com/pingcap/docs-cn/pull/3141/files#diff-9ed840ac86ca303f42c9a0609c6ed526R39

Make information-schema.md -> /information-schema/information-schema.md and fix dead links

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:

  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@yikeke yikeke added needs-cherry-pick-4.0 translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 24, 2020
@yikeke yikeke marked this pull request as ready for review July 27, 2020 11:34
@yikeke yikeke requested review from lilin90 and winoros July 27, 2020 11:35
@yikeke yikeke added the status/PTAL This PR is ready for reviewing. label Jul 27, 2020
@ti-srebot
Copy link
Contributor

@winoros, @lilin90, PTAL.

@lilin90 lilin90 added the size/large Changes of a large size. label Jul 30, 2020
@lilin90 lilin90 added the status/require-change Needs the author to address comments. label Jul 30, 2020
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@yikeke yikeke removed the status/require-change Needs the author to address comments. label Jul 30, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Jul 30, 2020

PTAL again @lilin90

@ti-srebot
Copy link
Contributor

@lilin90, @winoros, PTAL.

@ti-srebot
Copy link
Contributor

@yikeke, please update your pull request.

@ghost
Copy link

ghost commented Aug 3, 2020

LGTM

@ti-srebot
Copy link
Contributor

@nullnotnil,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@yikeke yikeke added the require-LGT1 Indicates that the PR requires an LGTM. label Aug 3, 2020
@yikeke
Copy link
Contributor Author

yikeke commented Aug 3, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 612b1d2 into pingcap:master Aug 3, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Aug 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #3508

@yikeke yikeke deleted the align-last-sw-changes branch August 3, 2020 06:47
ti-srebot added a commit that referenced this pull request Aug 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/large Changes of a large size. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants