-
Notifications
You must be signed in to change notification settings - Fork 709
faq, sql-statements: update out of date info (#3418) #3440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ti-srebot
merged 6 commits into
pingcap:release-3.1
from
ti-srebot:release-3.1-d4f13c983c02
Jul 29, 2020
Merged
faq, sql-statements: update out of date info (#3418) #3440
ti-srebot
merged 6 commits into
pingcap:release-3.1
from
ti-srebot:release-3.1-d4f13c983c02
Jul 29, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
Contributor
|
@nullnotnil Please apply v3.1-specific changes in this PR and delete |
|
@TomShawn Done |
TomShawn
reviewed
Jul 29, 2020
TomShawn
approved these changes
Jul 29, 2020
Contributor
TomShawn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Contributor
Author
|
/run-all-tests |
9 tasks
This was referenced Aug 12, 2020
mmyj
pushed a commit
to mmyj/docs
that referenced
this pull request
Aug 20, 2020
* Add Dashboard Access, Overview and Profiling Page * add empty documents to fix dead link * add profiling document * Update dashboard-access.md * update category * update 4 images * image changes from pingcap#3440 * Apply suggestions from code review Co-authored-by: Wenxuan <hi@breeswish.org> * address comments from lilian Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: Wenxuan <hi@breeswish.org> Co-authored-by: Lilian Lee <lilin@pingcap.com> Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
requires-version-specific-changes
After cherry-picked, the cherry-picked PR requires further changes.
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT1
Indicates that a PR has LGTM 1.
type/cherry-pick-for-release-3.1
This PR is cherry-picked to release-3.1 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3418 to release-3.1
What is changed, added or deleted? (Required)
This fixes some small errors in the FAQ and sql-statements guide:
-The FAQ implied optimistic locking was still the default, and said SELECT FOR UPDATE does not lock.
Which TiDB version(s) do your changes apply to? (Required)
This will require backporting, but the following version specific changes apply:
SELECT FOR UPDATEwill need rewording.What is the related PR or file link(s)?
Do your changes match any of the following descriptions?