Skip to content

Fix a typo about enabling tls #3801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 2, 2020
Merged

Fix a typo about enabling tls #3801

merged 4 commits into from
Sep 2, 2020

Conversation

@XiaoGe2030
Copy link

@XiaoGe2030 XiaoGe2030 commented Sep 2, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

I think it should be require x509。

I tested this SQL create user 'u1'@'%' require 509; . The error result returned is as follows

MySQL [(none)]> create user 'u1'@'%'  require 509;
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your TiDB version for the right syntax to use line 1 column 33 near "509"

create user 'u1'@'%' require x509; is right .

MySQL [(none)]> create user 'u1'@'%'  require x509;
Query OK, 0 rows affected (0.02 sec)

PS : I just want to try and submit a PR .
😃

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 2, 2020
@CLAassistant
Copy link

CLAassistant commented Sep 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lilin90 lilin90 changed the title found a typo Fix a typo Sep 2, 2020
@lilin90
Copy link
Member

lilin90 commented Sep 2, 2020

@XiaoGe2030 Would you please sign the CLA? Thanks!

@lilin90 lilin90 requested a review from lysu September 2, 2020 09:41
@lilin90 lilin90 added the size/small Changes of a small size. label Sep 2, 2020
@XiaoGe2030
Copy link
Author

XiaoGe2030 commented Sep 2, 2020

@XiaoGe2030 Would you please sign the CLA? Thanks!

What Can I do , I have updated emial and emial.

@XiaoGe2030
Copy link
Author

XiaoGe2030 commented Sep 2, 2020

@XiaoGe2030 Would you please sign the CLA? Thanks!

I have signed the CLA for pingcap/docs , Is there anything else I can do。

lysu
lysu reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
lilin90
lilin90 approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 2, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Sep 2, 2020
@lilin90
Copy link
Member

lilin90 commented Sep 2, 2020

@XiaoGe2030 Thanks for your contribution! Sharp eyes 👍

@lilin90 lilin90 changed the title Fix a typo Fix a typo about enabling tls Sep 2, 2020
@lilin90
Copy link
Member

lilin90 commented Sep 2, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 2, 2020
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 2, 2020

/run-all-tests

@ti-srebot ti-srebot merged commit 02e83f3 into pingcap:master Sep 2, 2020
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Sep 2, 2020
@ti-srebot
cherry pick pingcap#3801 to release-4.0
a676208 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Sep 2, 2020
Merged
5 tasks
@ti-srebot
Copy link
Contributor

ti-srebot commented Sep 2, 2020

cherry pick to release-4.0 in PR #3802

@lilin90 lilin90 added the translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. label Sep 2, 2020
lilin90 pushed a commit that referenced this pull request Sep 2, 2020
@ti-srebot
cherry pick #3801 to release-4.0 (#3802)
41f32f4 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: 刘校 <liuxiao23@jd.com>
@lilin90 lilin90 added the type/bugfix This PR fixes a bug. label Sep 2, 2020
@Oreoxmt Oreoxmt self-assigned this Nov 4, 2022
@Oreoxmt Oreoxmt added translation/doing This PR's assignee is translating this PR. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Nov 4, 2022
@Oreoxmt Oreoxmt mentioned this pull request Nov 4, 2022
Merged
14 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 4, 2022
This was referenced Nov 4, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

+1 more reviewer

@lysu lysu lysu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Oreoxmt Oreoxmt

Labels

contribution This PR is from a community contributor. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@XiaoGe2030 @CLAassistant @lilin90 @ti-srebot @lysu @Oreoxmt @2030XiaoGe