Skip to content

Conversation

@Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Mar 22, 2021

First-time contributors' checklist

What is changed, added or deleted? (Required)

Delete the file that does not apply for v4.0.

  • sql-statements/sql-statement-alter-index.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2021
@Joyinqin Joyinqin changed the title https://github.com/pingcap/docs/pull/4722 sql-statements: delete the file that does not apply for v4.0 Mar 22, 2021
@Joyinqin
Copy link
Contributor Author

/cc CharLotteiu

@ti-chi-bot ti-chi-bot requested a review from CharLotteiu March 22, 2021 08:10
@Joyinqin
Copy link
Contributor Author

/cc ran-huang

@ti-chi-bot ti-chi-bot requested a review from ran-huang March 22, 2021 08:10
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharLotteiu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2021
@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn

@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Mar 22, 2021
@ran-huang
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@Joyinqin: you cannot /lgtm your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin
Copy link
Contributor Author

/cc @TomShawn

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 23, 2021 02:37
@ran-huang
Copy link
Contributor

ran-huang commented Mar 23, 2021

You only need 1 LGTM for PR based on release-4.0, so bot won't read my LGTM

@TomShawn
Copy link
Contributor

@Joyinqin Could you provide the docs-cn PR from which this PR is translated?
image

@ti-chi-bot
Copy link
Member

@Joyinqin: These labels are not set on the issue: translation/from, translation/docs, translation/cn.

In response to this:

/remove-translation from docs cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

1 similar comment
@ti-chi-bot
Copy link
Member

@Joyinqin: These labels are not set on the issue: translation/from, translation/docs, translation/cn.

In response to this:

/remove-translation from docs cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin
Copy link
Contributor Author

/translation no-need

@ti-chi-bot ti-chi-bot added the translation/no-need No need to translate this PR. label Mar 23, 2021
@TomShawn
Copy link
Contributor

/remove-translation from-docs-cn

@ti-chi-bot ti-chi-bot removed the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 23, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 401ba1b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 23, 2021
@ti-chi-bot ti-chi-bot merged commit ddfe9f6 into pingcap:release-4.0 Mar 23, 2021
@Joyinqin Joyinqin deleted the delete-file branch March 23, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants