Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

make version check more compatible #381

Merged
merged 7 commits into from Nov 5, 2021

Conversation

glorv
Copy link
Collaborator

@glorv glorv commented Nov 5, 2021

What problem does this PR solve?

cherry-pick pingcap/tidb#29500 to release-5.2

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release note

@glorv glorv requested a review from lichunzhu November 5, 2021 07:40
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 5, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer approved (LGTM1) label Nov 5, 2021
@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 68f3bca

@glorv
Copy link
Collaborator Author

glorv commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 47a8ae6

@glorv
Copy link
Collaborator Author

glorv commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0feb50a

@glorv
Copy link
Collaborator Author

glorv commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 518a227

@glorv
Copy link
Collaborator Author

glorv commented Nov 5, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0e457cb

@ti-chi-bot ti-chi-bot merged commit 6f317de into pingcap:release-5.2 Nov 5, 2021
@glorv glorv deleted the tidb-version branch November 5, 2021 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants