Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't check StreamingCallSink is alive at close #211
There is nothing in place which guarantees that sending the last
There is currently a race condition where if the server responds
It isn't obvious to me what value this check_alive call is bringing; if
But as the check doesn't appear to provide any useful guarantees (and
This should be an expected behavior.
I don't think I understand you completely. It would be helpful if you can explain more details about your problem.
My assumption is that once the server has sent a message, further sends from the client cease to be allowed.
What I believe we're seeing is that the server is responding so quickly that the receiving half of the channel is closed before we start trying to close the sending half, and so we get an
(I can reproduce this semi-deterministically - about 20% of attempts with the right server behaviour set up on a localhost server, and can deterministically not reproduce it after this PR is applied)