Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock #1105

Merged

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Apr 21, 2023

@MyonKeminta MyonKeminta force-pushed the m/check-txn-status-primary-mismatch branch from 000d81f to 527a227 Compare April 23, 2023 05:52
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@MyonKeminta MyonKeminta changed the title Add new error type for indicating that check_txn_status is performed on non-primary Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock Apr 23, 2023
@MyonKeminta MyonKeminta marked this pull request as ready for review April 23, 2023 07:12
proto/kvrpcpb.proto Outdated Show resolved Hide resolved
Co-authored-by: ekexium <eke@fastmail.com>
@MyonKeminta MyonKeminta merged commit 72d9737 into pingcap:master Apr 24, 2023
zyguan added a commit that referenced this pull request May 10, 2023
* Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (#1105)

* Change implementation

* Fix typo in comment

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Update proto/kvrpcpb.proto

Co-authored-by: ekexium <eke@fastmail.com>

---------

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>

* Add error type for primary mismatch (#1107)

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

---------

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <9948422+MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>
MyonKeminta added a commit to MyonKeminta/kvproto that referenced this pull request May 23, 2023
… lock on the key (if any) is a real primary lock (pingcap#1105)

* Change implementation

* Fix typo in comment

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

* Update proto/kvrpcpb.proto

Co-authored-by: ekexium <eke@fastmail.com>

---------

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>
MyonKeminta added a commit that referenced this pull request May 24, 2023
…ith primary changed (#1120)

* Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (#1105)

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>
MyonKeminta added a commit to MyonKeminta/kvproto that referenced this pull request Jun 29, 2023
…ith primary changed

* Add a flag to CheckTxnStatusRequest to tell TiKV to check whether the lock on the key (if any) is a real primary lock (pingcap#1105)

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Co-authored-by: ekexium <eke@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants