Replace common.sh with Rust code #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
|
Ooops, I didn't know |
|
I'm fine with closing this but I'd like to listen to others' opinions. |
|
seems like a win to me? |
|
This should fix #355 |
Hoverbear
reviewed
Feb 25, 2019
| panic!( | ||
| "Invalid version of protoc (required 3.1.x), or protoc not installed\n\nstdout:\n\n{}", | ||
| String::from_utf8_lossy(&output.stdout) | ||
| "Invalid version of protoc (required 3.1.x, get {}.{}.x).", |
There was a problem hiding this comment.
Suggested change
| "Invalid version of protoc (required 3.1.x, get {}.{}.x).", | |
| "Invalid version of protoc (required 3.1.x, got {}.{}.x).", |
Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
|
PTAL @nrc |
sticnarf
pushed a commit
to sticnarf/kvproto
that referenced
this pull request
Oct 27, 2019
* Replace common.sh with Rust code Signed-off-by: ice1000 <ice1000kotlin@foxmail.com> * Add common.sh's content back Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ice1000 ice1000kotlin@foxmail.com
So we have fewer files in the root directory in this repo and no longer depend on
sed.