Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace common.sh with Rust code #358

Merged
merged 3 commits into from Feb 27, 2019
Merged

Replace common.sh with Rust code #358

merged 3 commits into from Feb 27, 2019

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Feb 24, 2019

Signed-off-by: ice1000 ice1000kotlin@foxmail.com

So we have fewer files in the root directory in this repo and no longer depend on sed.

Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
@ice1000 ice1000 requested a review from nrc Feb 24, 2019
@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented Feb 24, 2019

Ooops, I didn't know generate_go.sh depends on common.sh too...

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented Feb 24, 2019

I'm fine with closing this but I'd like to listen to others' opinions.

@nrc
Copy link
Contributor

@nrc nrc commented Feb 24, 2019

seems like a win to me?

@Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Feb 25, 2019

This should fix #355

panic!(
"Invalid version of protoc (required 3.1.x), or protoc not installed\n\nstdout:\n\n{}",
String::from_utf8_lossy(&output.stdout)
"Invalid version of protoc (required 3.1.x, get {}.{}.x).",
Copy link
Contributor

@Hoverbear Hoverbear Feb 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Invalid version of protoc (required 3.1.x, get {}.{}.x).",
"Invalid version of protoc (required 3.1.x, got {}.{}.x).",

Hoverbear
Hoverbear previously approved these changes Feb 25, 2019
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Please leave common.sh so the Go build can pass. We can fix #355 with this.

If you'd prefer, could you fix the functionality for the Go build? :)

The rest LGTM.

Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Copy link
Contributor

@Hoverbear Hoverbear left a comment

Rest LGTM

@ice1000
Copy link
Contributor Author

@ice1000 ice1000 commented Feb 26, 2019

PTAL @nrc

nrc
nrc approved these changes Feb 26, 2019
Copy link
Contributor

@nrc nrc left a comment

lgtm!

@ice1000 ice1000 merged commit e71ca01 into pingcap:master Feb 27, 2019
3 checks passed
sticnarf pushed a commit to sticnarf/kvproto that referenced this issue Oct 27, 2019
* Replace common.sh with Rust code

Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>

* Add common.sh's content back

Signed-off-by: ice1000 <ice1000kotlin@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants