Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: implement Restore for AlterTableStmt and AlterTableSpec #154

Merged
merged 10 commits into from Jan 12, 2019
Merged

parser: implement Restore for AlterTableStmt and AlterTableSpec #154

merged 10 commits into from Jan 12, 2019

Conversation

buzzers
Copy link
Contributor

@buzzers buzzers commented Jan 5, 2019

implement AlterTableStmt#Restore
implement AlterTableSpec#Restore
change parser_test.go#TestDDL

pingcap/tidb#8532

@zier-one zier-one changed the title [WIP]parser: implement Restore for AlterTableStmt and AlterTableSpec parser: implement Restore for AlterTableStmt and AlterTableSpec Jan 6, 2019
@zier-one zier-one mentioned this pull request Jan 6, 2019
Closed
@zier-one zier-one removed the WIP label Jan 9, 2019
zier-one
zier-one reviewed Jan 9, 2019
View reviewed changes
ast/ddl.go Show resolved Hide resolved
@buzzers
Copy link
Contributor Author

buzzers commented Jan 10, 2019

@leoppro PTAL

kennytm
kennytm reviewed Jan 10, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
kennytm
kennytm reviewed Jan 10, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
@buzzers
Copy link
Contributor Author

buzzers commented Jan 10, 2019

@leoppro @kennytm PTAL

kennytm
kennytm reviewed Jan 10, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
zier-one
zier-one reviewed Jan 11, 2019
View reviewed changes
ast/ddl.go Outdated Show resolved Hide resolved
zier-one
zier-one reviewed Jan 12, 2019
View reviewed changes
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
PTAL @kennytm

@zier-one zier-one added the status/LGT1 LGT1 label Jan 12, 2019
kennytm
kennytm approved these changes Jan 12, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Jan 12, 2019
@kennytm kennytm merged commit b7a3a36 into pingcap:master Jan 12, 2019
@buzzers buzzers deleted the restore_sql branch January 12, 2019 09:26
tiancaiamao pushed a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@kennytm
parser: implement Restore for AlterTableStmt and AlterTableSpec (ping…
eb0ed50 
…cap#154)

* implement AlterTableStmt#Restore.

* implement TableOption#Restore

* implement AlterTableSpec#Restore.
add test cases.

* resolved conversation

* resolved conversation: WritePlainf -> WriteString

* resolved: ctx.Annotate -> ctx.Annotatef

* resolved: merge ctx,WriteKeyWord

* resolved: merge if used else.

* implement PartitionDefinition#restore.

* change error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one left review comments

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
contribution status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buzzers @kennytm @zier-one