Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: fix lexer that treat 9eTSs as a float #208

Merged
merged 5 commits into from Feb 14, 2019
Merged

parser: fix lexer that treat 9eTSs as a float #208

merged 5 commits into from Feb 14, 2019

Conversation

tiancaiamao
Copy link
Collaborator

What problem does this PR solve?

Scan 9eTSs should get an identifier token

What is changed and how it works?

Fix pingcap/tidb#8983

Check List

Tests

  • Unit test

@tiancaiamao
parser: fix lexer that treat 9eTSs as a float
78bcd8d 
9eTSs should get an identifier
@tiancaiamao tiancaiamao added the type/bug-fix fix bug label Feb 14, 2019
@tiancaiamao
Copy link
Collaborator Author

PTAL @winoros @lysu

lysu
lysu reviewed Feb 14, 2019
View reviewed changes
lexer_test.go Show resolved Hide resolved
lysu
lysu reviewed Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 LGT1 label Feb 14, 2019
@tiancaiamao tiancaiamao removed the DNM label Feb 14, 2019
@tiancaiamao
Copy link
Collaborator Author

The rule is weird...

0x7fz != 0x7f + z
0b12 != 0b1 + 2
9e9a = 9e9 + a

I have some updates, PTAL @kennytm @lysu

kennytm
kennytm reviewed Feb 14, 2019
View reviewed changes
parser_test.go Outdated Show resolved Hide resolved
@lysu lysu removed the status/LGT1 LGT1 label Feb 14, 2019
kennytm
kennytm reviewed Feb 14, 2019
View reviewed changes
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lysu do you want to check again?

@kennytm kennytm added the status/LGT1 LGT1 label Feb 14, 2019
lysu
lysu approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Feb 14, 2019
@tiancaiamao tiancaiamao merged commit 6d10a0b into pingcap:master Feb 14, 2019
@tiancaiamao tiancaiamao deleted the fix-9eTSs branch February 14, 2019 12:14
tiancaiamao added a commit to tiancaiamao/parser that referenced this pull request Apr 27, 2021
@tiancaiamao
parser: fix lexer that treat 9eTSs as a float (pingcap#208)
bc25692
lyonzhi pushed a commit to lyonzhi/parser that referenced this pull request Apr 25, 2024
@tiancaiamao
parser: fix lexer that treat 9eTSs as a float (pingcap#208)
a7fc521
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
status/LGT2 LGT2 type/bug-fix fix bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiancaiamao @kennytm @lysu