Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MySQL extension assignment support for VariableAssignment #346

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@tangenta
Copy link
Contributor

commented Jun 4, 2019

What problem does this PR solve?

Support MySQL extension := syntax in variable assignment.

What is changed and how it works?

Modified parser.y

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

Related changes

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 4, 2019

CLA assistant check
All committers have signed the CLA.

@zz-jason
Copy link
Member

left a comment

LGTM

@zz-jason

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   53.37%   53.37%           
=======================================
  Files          31       31           
  Lines        6540     6540           
=======================================
  Hits         3491     3491           
  Misses       2707     2707           
  Partials      342      342
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb252e...1287918. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   53.37%   53.37%           
=======================================
  Files          31       31           
  Lines        6540     6540           
=======================================
  Hits         3491     3491           
  Misses       2707     2707           
  Partials      342      342
Impacted Files Coverage Δ
parser.go 70.58% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb252e...1287918. Read the comment docs.

@winkyao

winkyao approved these changes Jun 4, 2019

Copy link
Member

left a comment

LGTM

@winkyao winkyao merged commit 1e93bd0 into pingcap:master Jun 4, 2019

5 checks passed

ci/circleci: build-integration Your tests passed on CircleCI!
Details
ci/circleci: build-ut Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7cb252e...1287918
Details
codecov/project 53.37% remains the same compared to 7cb252e
Details
license/cla Contributor License Agreement is signed.
Details
@kennytm

kennytm approved these changes Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.