New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support add learner operator #1302

Merged
merged 5 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@overvenus
Member

overvenus commented Oct 30, 2018

What problem does this PR solve?

Support add-learner on pd-ctl.

Check List

Tests

  • Unit test

Code changes

  • Has HTTP API interfaces change

Related changes

  • Need to update the documentation

Close #1301

@overvenus overvenus force-pushed the ov/add-learner branch from 03187c3 to e7f79c9 Oct 30, 2018

*: support add learner operator
Signed-off-by: Neil Shen <overvenus@gmail.com>

@overvenus overvenus force-pushed the ov/add-learner branch from e7f79c9 to 4b780ca Oct 30, 2018

@disksing

This comment has been minimized.

Member

disksing commented Nov 1, 2018

@overvenus The learner peer may not work as you expected. Currently, PD only supports using learner as the intermediate state of AddPeer. Therefore the learner you added will be considered an abnormal state and will be cleaned up right away.
It may work after #1303.

@disksing

This comment has been minimized.

Member

disksing commented Nov 6, 2018

/run-unit-test

@overvenus overvenus force-pushed the ov/add-learner branch from 3b4c70a to f12ed4b Nov 26, 2018

nolouch and others added some commits Nov 26, 2018

@nolouch

This comment has been minimized.

Member

nolouch commented Nov 29, 2018

/run-unit-test

@overvenus overvenus merged commit c0c7b1a into master Nov 29, 2018

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@overvenus overvenus deleted the ov/add-learner branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment