Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Fix the issue about RaftCluster cannot be stopped #1370

Merged
merged 3 commits into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@nolouch
Copy link
Member

nolouch commented Dec 12, 2018

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

the RaftCluster probability can't stop cause by deadlock.

What is changed and how it works?

fix the mutex usage.

Check List

Tests

  • Unit test
server: fix the issue about RaftCluster cannot be stopped
Signed-off-by: nolouch <nolouch@gmail.com>
Show resolved Hide resolved server/cluster.go Outdated
Show resolved Hide resolved server/cluster_test.go Outdated

nolouch added some commits Dec 12, 2018

address comments
Signed-off-by: nolouch <nolouch@gmail.com>

@disksing disksing merged commit e8b8a8e into pingcap:master Dec 12, 2018

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

nolouch added a commit to nolouch/pd that referenced this pull request Dec 12, 2018

server: Fix the issue about RaftCluster cannot be stopped (pingcap#1370)
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>

@rleungx rleungx referenced this pull request Dec 12, 2018

Closed

pd return no leader error #1369

disksing added a commit that referenced this pull request Dec 12, 2018

server: Fix the issue about RaftCluster cannot be stopped (#1370) (#1375
)

* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>

@nolouch nolouch deleted the nolouch:fix-cluster-stop branch Dec 12, 2018

rleungx added a commit to rleungx/pd that referenced this pull request Dec 13, 2018

server: Fix the issue about RaftCluster cannot be stopped (pingcap#1370)
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch added a commit to nolouch/pd that referenced this pull request Dec 14, 2018

server: Fix the issue about RaftCluster cannot be stopped (pingcap#1370)
* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>

siddontang added a commit that referenced this pull request Dec 14, 2018

server: Fix the issue about RaftCluster cannot be stopped (#1370) (#1383
)

* server: fix the issue about RaftCluster cannot be stopped

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.