Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: check overlaps for new region #1377

Merged
merged 5 commits into from Dec 17, 2018

Conversation

Projects
None yet
3 participants
@Connor1996
Copy link
Member

Connor1996 commented Dec 13, 2018

What problem does this PR solve?

When a region is merged, and then PD receives a stale heartbeat of it for some kind of reasons. It may overlap with some regions and update region tree improperly.

What is changed and how it works?

When inserting a new region, check are there any overlapped regions and compare the version to decide whether the heartbeat is stale or not.

Check List

  • Unit test

Related changes

  • Need to be included in the release notes

Connor1996 added some commits Dec 13, 2018

@Connor1996 Connor1996 force-pushed the Connor1996:master branch from 7352150 to 20f8528 Dec 13, 2018

@Connor1996 Connor1996 requested review from nolouch, rleungx and disksing and removed request for nolouch Dec 13, 2018

@Connor1996

This comment has been minimized.

Copy link
Member Author

Connor1996 commented Dec 17, 2018

@Connor1996

This comment has been minimized.

Copy link
Member Author

Connor1996 commented Dec 17, 2018

/run-unit-test

Show resolved Hide resolved server/core/region.go Outdated
Show resolved Hide resolved server/api/stats_test.go Outdated
address comment
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

@Connor1996 Connor1996 force-pushed the Connor1996:master branch from 0e28df3 to 8e9e956 Dec 17, 2018

@Connor1996 Connor1996 merged commit 9d792fb into pingcap:master Dec 17, 2018

6 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

Connor1996 added a commit to Connor1996/pd that referenced this pull request Dec 17, 2018

server: check overlaps for new region (pingcap#1377)
Signed-off-by: Connor1996 <zbk602423539@gmail.com>

Connor1996 added a commit that referenced this pull request Dec 17, 2018

server: check overlaps for new region (#1377) (#1386)
Signed-off-by: Connor1996 <zbk602423539@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.