Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/leader: use the compact revision to watch leader #1396

Merged
merged 9 commits into from Dec 29, 2018

Conversation

@nolouch
Copy link
Member

commented Dec 26, 2018

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Use the current version may be lost the watch history, use compact version instead.

What is changed and how it works?

use the compact revision to watch leader

Check List

Tests

  • Unit test
  • Integration test
@nolouch nolouch added the kind/bug label Dec 26, 2018
@nolouch nolouch force-pushed the nolouch:use-minversion branch from b970b14 to e741d70 Dec 26, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch force-pushed the nolouch:use-minversion branch from e741d70 to 5b04088 Dec 26, 2018
@rleungx

This comment has been minimized.

Copy link
Member

commented Dec 26, 2018

/rebuild

@rleungx

This comment has been minimized.

Copy link
Member

commented Dec 26, 2018

/rebuild

server/leader.go Show resolved Hide resolved
nolouch added 4 commits Dec 27, 2018
Signed-off-by: nolouch <nolouch@gmail.com>
@nolouch nolouch requested review from rleungx and disksing Dec 28, 2018
nolouch added 3 commits Dec 28, 2018
Copy link
Contributor

left a comment

LGTM

@huachaohuang

This comment has been minimized.

Copy link
Contributor

commented Dec 29, 2018

Unit test keeps failing, does it related to this PR?

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

/run-unit-test

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

seems the ci environment not stable.

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Dec 29, 2018

/run-unit-test

@nolouch nolouch merged commit 5e5c092 into pingcap:master Dec 29, 2018
5 of 6 checks passed
5 of 6 checks passed
jenkins-ci-pd/unit-test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@nolouch nolouch deleted the nolouch:use-minversion branch Dec 29, 2018
nolouch added a commit to nolouch/pd that referenced this pull request Jan 3, 2019
* server/leader: use the compact revision to watch leader

Signed-off-by: nolouch <nolouch@gmail.com>
rleungx added a commit that referenced this pull request Jan 9, 2019
* server/leader: use the compact revision to watch leader

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.