Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add the scheduling configuration metrics #1406

Merged
merged 1 commit into from Jan 7, 2019

Conversation

@rleungx
Copy link
Member

commented Jan 3, 2019

What problem does this PR solve?

For now, we can only find the parameters of the configuration through the log, which is not friendly.

What is changed and how it works?

This PR adds some important configurations into metrics.

Check List

  • Need to update the documentation
  • Need to update the tidb-ansible repository
Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx rleungx added the area/metrics label Jan 3, 2019
@rleungx rleungx requested a review from nolouch Jan 3, 2019
disableReplaceOfflineReplica = 1
}

configs["disable_makeup_replica"] = disableMakeUpReplica

This comment has been minimized.

Copy link
@huachaohuang

huachaohuang Jan 3, 2019

Contributor

Can we just do configs["disable_makeup_replica"] = !s.opt.IsMakeUpReplicaEnabled()?

This comment has been minimized.

Copy link
@rleungx

rleungx Jan 3, 2019

Author Member

It seems we can not convert bool to float64 here.

Copy link
Contributor

left a comment

LGTM

@nolouch
nolouch approved these changes Jan 7, 2019
@huachaohuang huachaohuang merged commit 4bb9b96 into pingcap:master Jan 7, 2019
5 of 6 checks passed
5 of 6 checks passed
idc-jenkins-ci/build Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.