Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make hot region scheduler configurable #1412

Merged
merged 4 commits into from Jan 24, 2019

Conversation

@nolouch
Copy link
Member

commented Jan 17, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

In some situations, the hot region scheduling is too intense and affects the latency jitter.

What is changed and how it works?

let something in the hot region schedule be configurable.

Check List

Tests

  • Unit test

@nolouch nolouch force-pushed the nolouch:config-hot branch from 770aaea to 3af2334 Jan 17, 2019

*: make hot region scheduler configurable
Signed-off-by: nolouch <nolouch@gmail.com>
@codecov-io

This comment has been minimized.

Copy link

commented Jan 17, 2019

Codecov Report

Merging #1412 into master will increase coverage by 0.1%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1412     +/-   ##
=========================================
+ Coverage   67.52%   67.62%   +0.1%     
=========================================
  Files         157      157             
  Lines       14774    14800     +26     
=========================================
+ Hits         9976    10009     +33     
+ Misses       3874     3872      -2     
+ Partials      924      919      -5
Impacted Files Coverage Δ
server/schedule/basic_cluster.go 92.15% <ø> (-3.93%) ⬇️
server/config.go 82.18% <100%> (+0.39%) ⬆️
server/server.go 77.38% <100%> (-0.4%) ⬇️
server/option.go 91.25% <100%> (+2.78%) ⬆️
server/schedulers/hot_region.go 79.45% <71.42%> (-0.08%) ⬇️
server/cluster_info.go 87.47% <83.33%> (+0.05%) ⬆️
server/schedule/mockcluster.go 82.92% <90%> (+0.26%) ⬆️
server/schedulers/shuffle_hot_region.go 64.1% <0%> (-6.42%) ⬇️
server/util.go 71.12% <0%> (-2.82%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955da5d...004517c. Read the comment docs.

address comments
Signed-off-by: nolouch <nolouch@gmail.com>
@rleungx
Copy link
Member

left a comment

The rest LGTM.

Show resolved Hide resolved server/schedulers/hot_region.go
@huachaohuang

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

Seems this is a good case for a Schrodinger test :)

address comment
Signed-off-by: nolouch <nolouch@gmail.com>
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

/run-all-tests

@disksing disksing merged commit 8d6c936 into pingcap:master Jan 24, 2019

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the nolouch:config-hot branch Jan 24, 2019

nolouch added a commit to nolouch/pd that referenced this pull request May 29, 2019

*: make hot region scheduler configurable (pingcap#1412)
* *: make hot region scheduler configurable

Signed-off-by: nolouch <nolouch@gmail.com>

rleungx added a commit that referenced this pull request May 29, 2019

pick some hot region optimization to release 2.1 (#1551)
*: make hot region scheduler configurable (#1412)

Signed-off-by: nolouch <nolouch@gmail.com>

* use high priority for the hot region related operators (#1492)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.