New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Revert update etcd #1425

Merged
merged 3 commits into from Jan 31, 2019

Conversation

Projects
None yet
4 participants
@nolouch
Copy link
Member

nolouch commented Jan 31, 2019

What problem does this PR solve?

Meet some problems with the latest etcd, revert it firstly.

nolouch added some commits Jan 31, 2019

@nolouch nolouch requested review from disksing and rleungx Jan 31, 2019

@disksing

This comment has been minimized.

Copy link
Member

disksing commented Jan 31, 2019

/run-all-tests

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #1425 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
+ Coverage   67.67%   67.75%   +0.08%     
==========================================
  Files         158      158              
  Lines       15006    15006              
==========================================
+ Hits        10155    10168      +13     
- Misses       3918     3920       +2     
+ Partials      933      918      -15
Impacted Files Coverage Δ
pkg/logutil/log.go 83.62% <ø> (ø) ⬆️
tests/cluster.go 83.78% <ø> (ø) ⬆️
server/join.go 55.4% <ø> (ø) ⬆️
server/tso.go 74.41% <ø> (ø) ⬆️
server/util.go 73.94% <ø> (+2.81%) ⬆️
tools/pd-ctl/pdctl/command/global.go 41.66% <ø> (ø) ⬆️
server/etcd_kv.go 70.9% <ø> (+7.27%) ⬆️
server/api/utiletcdhttpapi.go 77.77% <ø> (ø) ⬆️
server/id.go 72.97% <ø> (ø) ⬆️
server/server.go 77.88% <ø> (+0.5%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db4a56...e9591f3. Read the comment docs.

@nolouch

This comment has been minimized.

Copy link
Member Author

nolouch commented Jan 31, 2019

/rebuild

@overvenus
Copy link
Member

overvenus left a comment

LGTM

@nolouch nolouch merged commit b93cac8 into pingcap:master Jan 31, 2019

9 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9db4a56...e9591f3
Details
codecov/project 67.75% (+0.08%) compared to 9db4a56
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the nolouch:revert branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment