Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: GetAllStores should not return tombstone stores (#1440) #1444

Merged
merged 1 commit into from Feb 27, 2019

Conversation

Projects
None yet
6 participants
@nolouch
Copy link
Member

commented Feb 26, 2019

What problem does this PR solve?

cherry pick #1440

@nolouch nolouch added the cherry-pick label Feb 26, 2019

@nolouch nolouch force-pushed the nolouch:pick-1440 branch from 9fab7bf to 6e49485 Feb 26, 2019

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@nolouch nolouch force-pushed the nolouch:pick-1440 branch from 6e49485 to 3b6b332 Feb 26, 2019

@nolouch nolouch requested review from rleungx, huachaohuang and disksing Feb 26, 2019

@nolouch nolouch added the WIP label Feb 26, 2019

@overvenus

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

pingcap/kvproto#361 has been merged, could you update kvproto?

@nolouch nolouch force-pushed the nolouch:pick-1440 branch 2 times, most recently from 4b84d0d to 2b8af24 Feb 26, 2019

server: GetAllStores should not return tombstone stores (#1440)
* server: add option to exclude tombstone stores

GetAllStores should not return tombstone stores in most cases. We can
add an option to support that if we needs it later.

Signed-off-by: Huachao Huang <huachao.huang@gmail.com>

@nolouch nolouch removed the WIP label Feb 26, 2019

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

1 similar comment
@nolouch

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/rebuild

1 similar comment
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/rebuild

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/rebuild

@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

1 similar comment
@zhouqiang-cl

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

/run-all-tests tidb=release-2.1 tikv=release-2.1 tidb-test=release-2.1

@huachaohuang
Copy link
Contributor

left a comment

LGTM

@disksing disksing merged commit 5eac798 into pingcap:release-2.1 Feb 27, 2019

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.