Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: let hot region balance not affect by balance-region-scheduler-limit #1522

Merged
merged 4 commits into from May 8, 2019

Conversation

Projects
None yet
4 participants
@nolouch
Copy link
Member

commented Apr 28, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

In some situation, the balance region has preempted the limiter, and the hot region balance has no chance to schedule.

What is changed and how it works?

change the AllowSchedule condition.

Check List

Tests

  • Unit test
schedulers: let hot region balance not affect by
`balance-region-scheduler-limit`

Signed-off-by: nolouch <nolouch@gmail.com>

@nolouch nolouch requested review from disksing and rleungx Apr 28, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #1522 into master will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
- Coverage    67.7%   67.66%   -0.05%     
==========================================
  Files         158      158              
  Lines       15648    15649       +1     
==========================================
- Hits        10595    10589       -6     
- Misses       4094     4096       +2     
- Partials      959      964       +5
Impacted Files Coverage Δ
server/schedulers/hot_region.go 75.45% <83.33%> (-1.39%) ⬇️
pkg/etcdutil/etcdutil.go 86.04% <0%> (-9.31%) ⬇️
server/util.go 70.86% <0%> (-7.29%) ⬇️
server/leader.go 80.49% <0%> (-2.49%) ⬇️
server/tso.go 72.72% <0%> (-2.28%) ⬇️
server/grpc_service.go 58.31% <0%> (-0.89%) ⬇️
server/cluster.go 74.26% <0%> (-0.54%) ⬇️
client/client.go 68.25% <0%> (+0.21%) ⬆️
server/namespace_cluster.go 85.71% <0%> (+1.29%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a02baa...6224e92. Read the comment docs.

@rleungx

rleungx approved these changes May 5, 2019

@disksing disksing merged commit 4573d20 into pingcap:master May 8, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the nolouch:hot-limit branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.