Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update some dead links #1543

Merged
merged 2 commits into from May 21, 2019
Merged

*: update some dead links #1543

merged 2 commits into from May 21, 2019

Conversation

@rleungx
Copy link
Member

rleungx commented May 20, 2019

What problem does this PR solve?

Closes #1542.

What is changed and how it works?

This PR updates some dead links of PD README.

Check List

Tests

  • No code
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@morgo

This comment has been minimized.

Copy link

morgo commented May 20, 2019

Please link to the public website instead :-) It supports redirects if URLs change, and it is good SEO practice to have a canonical location.

README.md Outdated
@@ -75,20 +75,20 @@ X-Etcd-Cluster-Id: 33dc747581249309

You can use the following command to build a PD image directly:

```
```sh

This comment has been minimized.

Copy link
@disksing

disksing May 21, 2019

Member

There are both bash and sh in the doc. Would you like to unify them?

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx

This comment has been minimized.

Copy link
Member Author

rleungx commented May 21, 2019

@morgo morgo self-requested a review May 21, 2019
@morgo
morgo approved these changes May 21, 2019
Copy link

morgo left a comment

LGTM

@nolouch nolouch merged commit 9ffc18f into pingcap:master May 21, 2019
4 of 5 checks passed
4 of 5 checks passed
idc-jenkins-ci/test Jenkins job failed
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
nolouch added a commit that referenced this pull request May 23, 2019
* tiny clean up code (#1526)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config:  enable use region storage by default (#1524)

* config: default enable use region storage

* schedulers: let hot region balance not affect by balance-region-scheduler-limit (#1522)

Signed-off-by: nolouch <nolouch@gmail.com>

* log: do not add stack to error log (#1532)

* *: replace gofail with pingcap/failpoint (#1534)

* *: replace gofail with pingcap/failpoint

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* fix typo

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster_test.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* Update server/tso.go

Co-Authored-By: Lonng <chris@lonng.org>

* check enable failpoint result

Signed-off-by: disksing <i@disksing.com>

* Update server/cluster.go

Co-Authored-By: Lonng <chris@lonng.org>

* server: set timeout for MoveLeader (#1533)

* server: set timeout for MoveLeader

Signed-off-by: disksing <i@disksing.com>

* client, server: add ScanRegions gRPC protocol support (#1535)

* client, server: support ScanRegions gRPC protocol

Signed-off-by: disksing <i@disksing.com>

* schedule: actively push operator  (#1536)

* schedule: actively push operator

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update some dead links (#1543)

* update links

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Add windows build script (#1540)

Signed-off-by: Ana Hobden <operator@hoverbear.org>

* fix operator timeout metrics (#1541)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* *:Rollback config in store when kv.persist failed (#1476)

* tests: independent region sync test (#1545)

* tests: independent syncer region test

Signed-off-by: nolouch <nolouch@gmail.com>

* schedule: operator limit for stores (#1474)

* add store limit for scheduling

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* statistic: add the statistic of flow (#1548)

* store_statistic: add the statistic of flow

Signed-off-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.