Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: check replica for hot region #1609

Merged
merged 4 commits into from Jul 5, 2019

Conversation

Projects
None yet
4 participants
@rleungx
Copy link
Member

commented Jul 2, 2019

What problem does this PR solve?

We don't check the number of replicas when scheduling the hot region.

What is changed and how it works?

This PR improves it by checking if it is lack of replicas or has learner peer, just like the balance region does.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release notes

rleungx added some commits Jul 2, 2019

check replica for hot region scheduler
Signed-off-by: Ryan Leung <rleungx@gmail.com>
address comments
Signed-off-by: Ryan Leung <rleungx@gmail.com>
address comment
Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx force-pushed the rleungx:check-replica-hot-region branch from a84c083 to b4bbebc Jul 4, 2019

@nolouch

nolouch approved these changes Jul 5, 2019

@nolouch nolouch merged commit f662591 into pingcap:master Jul 5, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

rleungx added a commit to rleungx/pd that referenced this pull request Jul 10, 2019

scheduler: check replica for hot region (pingcap#1609)
* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx referenced this pull request Jul 10, 2019

Merged

*: some fixes for release 3.0 #1624

4 of 4 tasks complete

nolouch added a commit that referenced this pull request Jul 11, 2019

*: some fixes for release 3.0 (#1624)
* schedulers: balance region consider pending peer (#1617)

* schedulers: balance region consider pending peers

Signed-off-by: nolouch <nolouch@gmail.com>

* scheduler: check replica for hot region  (#1609)

* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: set influence according to region size (#1613)

* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config: turn the default limit of the hot region schedule (#1616)

* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

* update CHANGELOG

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.