Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: set influence according to region size #1613

Merged
merged 4 commits into from Jul 5, 2019

Conversation

Projects
None yet
4 participants
@rleungx
Copy link
Member

commented Jul 3, 2019

What problem does this PR solve?

Currently, the store limit may influence the speed of merge. And some users hope to merge the region very fast.

What is changed and how it works?

This PR eases this restriction by replacing AddLearner and AddPeer with AddLightLearner and AddLightPeer respectively. The behavior is just like before we introduce store limit.

Update:
We still use AddLearner and AddPeer, but set the influence according to the region size.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release notes
not consider store limit when executing merge
Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx requested review from nolouch and disksing Jul 3, 2019

@disksing

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

Can update store limit increase the merge speed?

@rleungx rleungx changed the title checker: not consider store limit when executing merge schedule: set influence according to region size Jul 4, 2019

set influence according to region size
Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx force-pushed the rleungx:no-limit-merge branch from 63ce2cf to 66e1d75 Jul 4, 2019

Show resolved Hide resolved server/schedule/operator.go Outdated

rleungx added some commits Jul 4, 2019

fix race problems
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@nolouch

nolouch approved these changes Jul 4, 2019

Copy link
Member

left a comment

LGTM

@shafreeck
Copy link
Contributor

left a comment

LGTM

@disksing disksing merged commit c7052f6 into pingcap:master Jul 5, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

rleungx added a commit to rleungx/pd that referenced this pull request Jul 10, 2019

schedule: set influence according to region size (pingcap#1613)
* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

@rleungx rleungx referenced this pull request Jul 10, 2019

Merged

*: some fixes for release 3.0 #1624

4 of 4 tasks complete

nolouch added a commit that referenced this pull request Jul 11, 2019

*: some fixes for release 3.0 (#1624)
* schedulers: balance region consider pending peer (#1617)

* schedulers: balance region consider pending peers

Signed-off-by: nolouch <nolouch@gmail.com>

* scheduler: check replica for hot region  (#1609)

* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: set influence according to region size (#1613)

* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config: turn the default limit of the hot region schedule (#1616)

* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

* update CHANGELOG

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.