Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: turn the default limit of the hot region schedule #1616

Merged
merged 4 commits into from Jul 4, 2019

Conversation

Projects
None yet
4 participants
@nolouch
Copy link
Member

commented Jul 3, 2019

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

now, the balance-region-limit already enlarge, also make hot-region-schedule-limit more suitable.

What is changed and how it works?

enlarge limit.

Check List

Tests

  • Unit test
  • Integration test
config: turn the default limit of the hot region schedule
Signed-off-by: nolouch <nolouch@gmail.com>
try to fix ci
Signed-off-by: nolouch <nolouch@gmail.com>
@disksing

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

Should it be mentioned in release note? Because users need to manually update config value for old clusters.

@nolouch

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@disksing Yes, we should. also, update the 3.0 upgrade guide.

@shafreeck
Copy link
Contributor

left a comment

LGTM

@rleungx

rleungx approved these changes Jul 4, 2019

@nolouch nolouch added the release-note label Jul 4, 2019

@nolouch nolouch merged commit bfcee70 into pingcap:master Jul 4, 2019

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@nolouch nolouch deleted the nolouch:fix-conf branch Jul 4, 2019

rleungx added a commit to rleungx/pd that referenced this pull request Jul 10, 2019

config: turn the default limit of the hot region schedule (pingcap#1616)
* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

@rleungx rleungx referenced this pull request Jul 10, 2019

Merged

*: some fixes for release 3.0 #1624

4 of 4 tasks complete

nolouch added a commit that referenced this pull request Jul 11, 2019

*: some fixes for release 3.0 (#1624)
* schedulers: balance region consider pending peer (#1617)

* schedulers: balance region consider pending peers

Signed-off-by: nolouch <nolouch@gmail.com>

* scheduler: check replica for hot region  (#1609)

* check replica for hot region scheduler

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: set influence according to region size (#1613)

* not consider store limit when executing merge

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* set influence according to region size

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* fix race problems

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* config: turn the default limit of the hot region schedule (#1616)

* config: turn the default limit of the hot region schedule

Signed-off-by: nolouch <nolouch@gmail.com>

* update CHANGELOG

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.