Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer: support TLS for region syncer (#1728) #1739

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@rleungx
Copy link
Member

commented Sep 9, 2019

What problem does this PR solve?

cherry-pick #1728.

What is changed and how it works?

To solve the conflicts, this PR does some change to ToTLSConfig and add a new function ConvertToMap for SecurityConfig

Check List

Tests

  • Unit test
  • Manual test
rleungx added 2 commits Sep 5, 2019
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx added the cherry-pick label Sep 9, 2019
@rleungx rleungx requested review from nolouch, disksing and lhy1024 Sep 9, 2019
@nolouch

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/run-all-tests

@nolouch

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

/run-all-tests

@nolouch nolouch added the status/LGT1 label Sep 10, 2019
@sre-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

Your auto merge job has been accepted, waiting for 1755

@sre-bot

This comment has been minimized.

Copy link

commented Sep 12, 2019

/run-all-tests

@sre-bot sre-bot merged commit dc03c83 into pingcap:release-3.0 Sep 12, 2019
8 checks passed
8 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-compatibility-test Jenkins job succeeded.
Details
idc-jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.