Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add profile CPU/memory/mutex/allocs/block/goroutine HTTP API #1965

Merged
merged 1 commit into from Nov 25, 2019

Conversation

@lonng
Copy link
Member

lonng commented Nov 25, 2019

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

This PR adds profile CPU/memory/mutex/allocs/block/goroutine HTTP API and make profile cluster component via SQL possible. (Part of pingcap/tidb#13567)

What is changed and how it works?

Add HTTP API for PD.

Check List

Tests

  • No code

Code changes

  • Has HTTP API interfaces change (Don't forget to [update API document]
Signed-off-by: Lonng <heng@lonng.org>
@lonng lonng added the area/api label Nov 25, 2019
@lonng lonng added this to In progress in Built-in SQL Diagnostics Nov 25, 2019
@lonng lonng mentioned this pull request Nov 25, 2019
26 of 60 tasks complete
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 25, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@cdd258b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1965   +/-   ##
=========================================
  Coverage          ?   77.95%           
=========================================
  Files             ?      171           
  Lines             ?    17216           
  Branches          ?        0           
=========================================
  Hits              ?    13420           
  Misses            ?     2755           
  Partials          ?     1041
Impacted Files Coverage Δ
server/api/router.go 99.13% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd258b...725c747. Read the comment docs.

Copy link
Contributor

shafreeck left a comment

LGTM

Copy link
Member

crazycs520 left a comment

LGTM

@lonng lonng merged commit 55f3ddf into pingcap:master Nov 25, 2019
5 checks passed
5 checks passed
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
idc-jenkins-ci/build Jenkins job succeeded.
Details
idc-jenkins-ci/test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
@lonng lonng deleted the lonng:perf-api branch Nov 25, 2019
@lonng lonng moved this from In progress to Done in Built-in SQL Diagnostics Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.