New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server/*: refactor AllocPeer #2073
Conversation
Signed-off-by: disksing <i@disksing.com>
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
=========================================
+ Coverage 76.77% 76.98% +0.2%
=========================================
Files 191 191
Lines 19332 19294 -38
=========================================
+ Hits 14842 14853 +11
+ Misses 3368 3339 -29
+ Partials 1122 1102 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
CI problem. re-run. |
/merge |
1 similar comment
/merge |
/run-all-tests |
Signed-off-by: disksing i@disksing.com
What problem does this PR solve?
IDs may be wasted because
AllocPeer
is called too early. See #1924Now we use
operator.Builder
to create operators. Since it supports allocating ID automatically, we can defer ID allocation to Builder.What is changed and how it works?
Check List
Tests