Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd-web: remove #2121

Merged
merged 3 commits into from Feb 12, 2020
Merged

pd-web: remove #2121

merged 3 commits into from Feb 12, 2020

Conversation

HunDunDM
Copy link
Member

Signed-off-by: hundundm hundundm@gmail.com

What problem does this PR solve?

Removed pd-web and keyvisualService. They will be replaced by Dashboard.

What is changed and how it works?

Check List

@HunDunDM HunDunDM added the component/visualization Visualization. label Feb 12, 2020
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #2121 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
+ Coverage   76.82%   76.89%   +0.06%     
==========================================
  Files         194      192       -2     
  Lines       19990    19899      -91     
==========================================
- Hits        15358    15302      -56     
+ Misses       3482     3453      -29     
+ Partials     1150     1144       -6
Impacted Files Coverage Δ
tests/cluster.go 85.76% <ø> (-0.06%) ⬇️
server/server.go 80.25% <ø> (-0.32%) ⬇️
pkg/apiutil/serverapi/middleware.go 73.03% <0%> (-8.99%) ⬇️
server/schedulers/base_scheduler.go 60.86% <0%> (-8.7%) ⬇️
server/tso/tso.go 81.75% <0%> (-2.19%) ⬇️
server/grpc_service.go 57.29% <0%> (-1.08%) ⬇️
server/schedulers/adjacent_region.go 75.4% <0%> (-1.07%) ⬇️
pkg/btree/btree.go 87.65% <0%> (+0.8%) ⬆️
client/base_client.go 86.2% <0%> (+1.37%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9bcbc...6a3dbb7. Read the comment docs.

@nolouch nolouch added this to the v4.0.0-beta.1 milestone Feb 12, 2020
@nolouch nolouch added the needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. label Feb 12, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Feb 12, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 12, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7a3ae12 into tikv:master Feb 12, 2020
@sre-bot sre-bot mentioned this pull request Feb 12, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 12, 2020

cherry pick to release-3.1 in PR #2122

sre-bot added a commit that referenced this pull request Feb 12, 2020
@rleungx rleungx mentioned this pull request Feb 20, 2020
@HunDunDM HunDunDM deleted the remove-pd-web branch August 21, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/visualization Visualization. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants