Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push metrics #325

Merged
merged 4 commits into from Sep 18, 2016
Merged

Push metrics #325

merged 4 commits into from Sep 18, 2016

Conversation

@overvenus
Copy link
Member

overvenus commented Sep 14, 2016

Please review b19e15c

Close #321

Ref tikv/tikv#1065

@siddontang

This comment has been minimized.

Copy link
Member

siddontang commented Sep 14, 2016

LGTM

@siddontang

This comment has been minimized.

Copy link
Member

siddontang commented Sep 17, 2016

addr,
prometheus.DefaultGatherer,
); err != nil {
fmt.Println("Could not push metrics to Prometheus Pushgateway:", err)

This comment has been minimized.

Copy link
@huachaohuang

huachaohuang Sep 17, 2016

Contributor

Shouldn't we use log here?

// MetricConfig is the metric configuration.
type MetricConfig struct {
PushAddress string `toml:"address" json:"address"`
PushInterval time.Duration `toml:"interval" json:"interval"`

This comment has been minimized.

Copy link
@huachaohuang

huachaohuang Sep 17, 2016

Contributor

time.Duration can not be parsed by toml, you can use the duration instead.

@huachaohuang

This comment has been minimized.

Copy link
Contributor

huachaohuang commented Sep 18, 2016

LGTM

@overvenus overvenus merged commit c484751 into pingcap:master Sep 18, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@shenli shenli mentioned this pull request Sep 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.