New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove unix socket. #684

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@disksing
Member

disksing commented Jul 18, 2017

As etcd does not support unix socket, using unix socket in tests improves nothing and introduces complexity.

cc @nolouch @siddontang @huachaohuang

Show outdated Hide outdated server/api/server_test.go
@@ -50,43 +48,21 @@ var (
},
Peers: peers,
}
unixClient = newUnixSocketClient()
)
func TestAPIServer(t *testing.T) {
TestingT(t)
}
func newUnixSocketClient() *http.Client {

This comment has been minimized.

@siddontang

siddontang Jul 18, 2017

Member

need to remove this?

@siddontang

siddontang Jul 18, 2017

Member

need to remove this?

Show outdated Hide outdated pkg/testutil/testutil.go
if err != nil {
log.Fatal(err)
}
err = l.Close()

This comment has been minimized.

@siddontang

siddontang Jul 18, 2017

Member

should get the address before close?

@siddontang

siddontang Jul 18, 2017

Member

should get the address before close?

Show outdated Hide outdated server/api/redirector.go
p.urls = append(p.urls, u)
p.clients = append(p.clients, client)
p.clients = append(p.clients, &http.Client{})

This comment has been minimized.

@huachaohuang

huachaohuang Jul 18, 2017

Member

We don't need multiple clients anymore.

@huachaohuang

huachaohuang Jul 18, 2017

Member

We don't need multiple clients anymore.

@nolouch

LGTM

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
Member

huachaohuang commented Jul 19, 2017

LGTM

@siddontang siddontang merged commit f4fbc5a into master Jul 19, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@siddontang siddontang deleted the disksing/unix branch Jul 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment