GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operators may be accessed concurrently, should be mutex guarded.
*: fix a data race.
What cause the data race?
Seems not a good idea to add lock to every operator?
Here for instance:
Lines 96 to 106
These defers can be refactor to:
res := jsonString(op)
Cost of defer in such small functions may be relatively big.
operators would not be performance bottleneck, so I prefer readability to performance here.
Merge branch 'master' into disksing/race
if error, should panic?
Only for logging, ok to ignore it, I guess.