New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: fix heartbeat stream bug. #709

Merged
merged 2 commits into from Aug 21, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Aug 17, 2017

The bug:
We create heartbeatStreams in coordinator to manage async region heartbeats. If pd-server loses leadership then quickly becomes leader again, a new coordinator will be created, but grpc steams are still bind to the old one, then scheduler commands will not be able to send to tikv.

The fix:
Create heartbeatStreams along with Server, coordinator only keeps a reference.

@disksing disksing requested review from siddontang, nolouch and huachaohuang Aug 17, 2017

@siddontang

LGTM

@disksing disksing merged commit 91bc03d into master Aug 21, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/hbstream branch Aug 21, 2017

disksing added a commit to disksing/pd that referenced this pull request Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment