New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: remove timeout for streaming call. #711

Merged
merged 2 commits into from Aug 24, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Aug 23, 2017

We should not use WithTimeout for streaming calls, which will close the stream after timeout.

@disksing disksing requested review from siddontang, shenli and tiancaiamao Aug 23, 2017

@disksing disksing changed the title from client: use failFast flag instead of timeout. to client: remove timeout for streaming call. Aug 23, 2017

@siddontang

LGTM

@nolouch

This comment has been minimized.

Show comment
Hide comment
@nolouch

nolouch Aug 23, 2017

Member

LGTM.

Member

nolouch commented Aug 23, 2017

LGTM.

@disksing disksing merged commit 38eb8a2 into master Aug 24, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/timeout branch Aug 24, 2017

@disksing disksing referenced this pull request Aug 24, 2017

Merged

vendor: update pd. #4308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment