New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: extract replica selector. #717

Merged
merged 1 commit into from Sep 1, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Aug 31, 2017

No description provided.

@disksing disksing requested review from nolouch and huachaohuang Aug 31, 2017

@siddontang

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 1, 2017

Member
cache_test.go:468:
    c.Assert(cache.handleRegionHeartbeat(r), IsNil)
... value *errors.Err = &errors.Err{message:"", cause:(*errors.Err)(0xc420061b30), previous:(*errors.Err)(0xc42080a730), file:"github.com/pingcap/pd/server/_test/_obj_test/cache.go", line:886} ("failed to commit transaction")

CI fails due to etcd not responding.

Member

disksing commented Sep 1, 2017

cache_test.go:468:
    c.Assert(cache.handleRegionHeartbeat(r), IsNil)
... value *errors.Err = &errors.Err{message:"", cause:(*errors.Err)(0xc420061b30), previous:(*errors.Err)(0xc42080a730), file:"github.com/pingcap/pd/server/_test/_obj_test/cache.go", line:886} ("failed to commit transaction")

CI fails due to etcd not responding.

@disksing disksing merged commit 3b62d33 into master Sep 1, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/replica-selector branch Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment