New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: move admin schedulers into schedulers directory. #728

Merged
merged 1 commit into from Sep 4, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Sep 4, 2017

No description provided.

@disksing disksing requested review from nolouch and huachaohuang Sep 4, 2017

@@ -131,9 +131,9 @@ func (l *balanceLeaderScheduler) Schedule(cluster *clusterInfo) schedule.Operato
schedulerCounter.WithLabelValues(l.GetName(), "skip").Inc()
return nil
}
l.limit = adjustBalanceLimit(cluster, l.GetResourceKind())
l.limit = adjustBalanceLimit(cluster.(*clusterInfo), l.GetResourceKind())

This comment has been minimized.

@disksing

disksing Sep 4, 2017

Member

The type assertion will be removed after it been move to schedulers directory.

@disksing

disksing Sep 4, 2017

Member

The type assertion will be removed after it been move to schedulers directory.

prometheus.CounterOpts{
Namespace: "pd",
Subsystem: "scheduler",
Name: "event_count_wip",

This comment has been minimized.

@disksing

disksing Sep 4, 2017

Member

The _wip suffix is to avoid conflict with the old one. It will be removed after all schedulers are moved into schedulers directory.

@disksing

disksing Sep 4, 2017

Member

The _wip suffix is to avoid conflict with the old one. It will be removed after all schedulers are moved into schedulers directory.

@nolouch

nolouch approved these changes Sep 4, 2017

LGTM

@huachaohuang

LGTM

@disksing disksing merged commit 6f568f3 into master Sep 4, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/move7 branch Sep 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment