New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedulers: dependency inverse. #731

Merged
merged 2 commits into from Sep 5, 2017

Conversation

Projects
None yet
5 participants
@disksing
Member

disksing commented Sep 4, 2017

No description provided.

@disksing disksing requested review from nolouch and huachaohuang Sep 4, 2017

@nolouch

nolouch approved these changes Sep 4, 2017

LGTM!

@siddontang

This comment has been minimized.

Show comment
Hide comment
@siddontang
Member

siddontang commented Sep 4, 2017

LGTM

PTAL @huachaohuang

@huachaohuang

This comment has been minimized.

Show comment
Hide comment
@huachaohuang

huachaohuang Sep 5, 2017

Member

Should we use a consistent name for scheduler creation and the scheduler's name?

Member

huachaohuang commented Sep 5, 2017

Should we use a consistent name for scheduler creation and the scheduler's name?

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Member

/build

Member

iamxy commented Sep 5, 2017

/build

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Member

/run-full-test

Member

iamxy commented Sep 5, 2017

/run-full-test

@iamxy

This comment has been minimized.

Show comment
Hide comment
@iamxy

iamxy Sep 5, 2017

Member

/run-integration-test

Member

iamxy commented Sep 5, 2017

/run-integration-test

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 5, 2017

Member

@huachaohuang Don't worry, they will go to config file.

Member

disksing commented Sep 5, 2017

@huachaohuang Don't worry, they will go to config file.

@disksing disksing merged commit 7b9052c into master Sep 5, 2017

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/move10 branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment