New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should use time.Since instead of time.Now().Sub #736

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
5 participants
@wgliang
Contributor

wgliang commented Sep 6, 2017

should use time.Since instead of time.Now().Sub

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 6, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Sep 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Sep 6, 2017

CLA assistant check
All committers have signed the CLA.

@disksing

LGTM.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 6, 2017

Member

@wgliang thanks for your contribution!

Member

disksing commented Sep 6, 2017

@wgliang thanks for your contribution!

@disksing disksing merged commit d15068c into pingcap:master Sep 6, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment