New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: refactor operators. #737

Merged
merged 7 commits into from Sep 7, 2017

Conversation

Projects
None yet
3 participants
@disksing
Member

disksing commented Sep 6, 2017

No description provided.

@disksing disksing requested a review from nolouch Sep 6, 2017

@disksing disksing requested a review from huachaohuang Sep 6, 2017

Show outdated Hide outdated server/schedule/operator.go
Show outdated Hide outdated server/schedule/replica_checker.go
operators = append(operators, op)
}
}
return operators
}
func (c *coordinator) sendScheduleCommand(region *core.RegionInfo, step schedule.OperatorStep) {

This comment has been minimized.

@nolouch

nolouch Sep 6, 2017

Member

add a log to descript the step

@nolouch

nolouch Sep 6, 2017

Member

add a log to descript the step

disksing added some commits Sep 6, 2017

}
// Operator contains execution steps generated by scheduler.
type Operator struct {

This comment has been minimized.

@huachaohuang

huachaohuang Sep 6, 2017

Member

Should add some tests for operators in this file.

@huachaohuang

huachaohuang Sep 6, 2017

Member

Should add some tests for operators in this file.

@huachaohuang

LGTM

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 7, 2017

Member

/run-full-test

Member

disksing commented Sep 7, 2017

/run-full-test

@disksing disksing merged commit 5f391b7 into master Sep 7, 2017

8 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
jenkins-ci-pd/integration-common-test Jenkins job succeeded.
Details
jenkins-ci-pd/integration-ddl-test Jenkins job succeeded.
Details
jenkins-ci-pd/unit-test Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@disksing disksing deleted the disksing/operator branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment