New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, add plugable cache framework #740

Merged
merged 3 commits into from Sep 7, 2017

Conversation

Projects
None yet
4 participants
@blacktear23
Contributor

blacktear23 commented Sep 7, 2017

As @ngaut mentioned add a plugable cache framework for PD.

@sre-bot

This comment has been minimized.

Show comment
Hide comment
@sre-bot

sre-bot Sep 7, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

sre-bot commented Sep 7, 2017

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 7, 2017

Member

Hi, @blacktear23 , please run make dev to pass all code checks.

Member

disksing commented Sep 7, 2017

Hi, @blacktear23 , please run make dev to pass all code checks.

yulai.li and others added some commits Sep 7, 2017

@disksing

This comment has been minimized.

Show comment
Hide comment
@disksing

disksing Sep 7, 2017

Member

/ok-to-test

Member

disksing commented Sep 7, 2017

/ok-to-test

@disksing

LGTM.

@nolouch

nolouch approved these changes Sep 7, 2017

LGTM

@disksing disksing merged commit 335f5af into pingcap:master Sep 7, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci-pd/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment